Separates Factions In Observe/Follow Tab #5058
Conversation
|
Will this also seperate the Liaison or the UPP survivors for example? |
|
requested changes made |
There was a problem hiding this comment.
I am almost certain this will cause unintended behavior where this list is used here: https://github.com/cmss13-devs/cmss13/blob/master/code/__HELPERS/unsorted.dm#L676
As in I do not expect a FACTION_WY_DEATHSQUAD ert to add any of those mobs as candidates.
May be moot though because its usage is only in getertmembers which I see no references to.
Drulikar
added
Testmerge Candidate
|
I'll update changes in a few days when I have the free time. |
|
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself |
|
Death squad and WY PMC synths will now be separated. Other changes made. I did some testing and this seems to work. Survivors are still listed as survivors no matter what faction they belong to. |
|
I might want to consider adding a separate category for USCM ERT's like Marsoc and CBRN since they fall under the regular Marine list. Also I should separate Provost. Edit: Might break things if I try that, so it'll have to stay as it is. |
# About the pull request <!-- Remove this text and explain what the purpose of your PR is. Mention if you have tested your changes. If you changed a map, make sure you used the mapmerge tool. If this is an Issue Correction, you can type "Fixes Issue #169420" to link the PR to the corresponding Issue number #169420. Remember: something that is self-evident to you might not be to others. Explain your rationale fully, even if you feel it goes without saying. --> ERT factions no longer show up in the escape section. This issue was caused by #5058 # Explain why it's good for the game Makes it clearer who has actually escaped and not ERT returning to their base. # Testing Photographs and Procedure <details> <summary>Screenshots & Videos</summary> Put screenshots and videos here with an empty line between the screenshots and the `<details>` tags. </details> # Changelog :cl: fix: ERT no longer show up in the orbit escape section /:cl:
About the pull request
Separates the factions from a generic 'ERT Faction' tab into their own separate one's for each of the main factions, this includes.
The remaining factions (mostly memes, unused or admin ones) are kept in the current 'ERT' panel.
Explain why it's good for the game
Better gauge as a observer who the present factions are, helps in the uncommon circumstances where multiple factions are in play.
Testing Photographs and Procedure
Screenshots & Videos
Put screenshots and videos here with an empty line between the screenshots and the
<details>tags.Changelog
🆑
add: Factions are now properly separated in the observe menu as a ghost.
/:cl: